-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pip bundle
from pip2pi
#19
Conversation
…take the last path part
There are a series of commits where I was making my own pip-manifest.txt for comparison sake. I abuse branches, forgetting pull requests show the entire commit stack anyway :) |
Interesting! Doing a quick binary search, it looks like Anyway, this looks awesome. I'll be doing some testing to make sure it doesn't break things, but I'm excited to get this merged. The only thing: could you add an explicit version check for I'd like this because 1.1 isn't quite two years old yet, so I expect we'll find people in the wild using it… and the failure — that only the specified packages, and not their dependencies — will be surprising and hard to track down. |
That should do it. Let me know if it feels ok now. Thanks :) |
Feelin' awesome! I'll test this over the next couple of days, then cut a release. Also, if you're working on stuff… would you mind switching it up from using |
I am working on (just about done) making In the meantime, I can totally put in the |
Woo! That would be incredible! Also, I would be totally up for making dir2pi more similar to pypi.python.org/simple, and especially if there was some way to easily push it to s3. I've actually been thinking about rejigging things there just a bit, since there's a bug right now where new package page indexes overwrite old ones… so, for example, if you run |
Shoot, hadn't thought about backends. Part of the reason I wrote this was to support multiple package versions. Basically, it goes like this:
But when I submit the pull request, take a look at what's happening and see if it makes sense. This should work very well with rsync. Putting in an S3 backend might be something I tackle next. |
Okay, will do. Ya, that's basically what I was going to do as well. Let me know if you're getting blocked on something — having someone ready to submit patches against this feature would be some good motivation to get it done ;) |
…. Falls back to old method.
This should address #5 and your concerns with versions < 1.1, and take advantage of pip.main. |
By the way, here's an about-finished first pass at reworking Simple indexing, multiple-package-versions, index updating, and whatnot. |
Awesome. Can you submit a pull request so we can discuss there?
(416) 906-0403 |
I can't submit another pull request until this one is accepted. Is that something you plan to do in the near future? Thanks! Dave |
Urg! Sorry! I didn't realize you could only have one open PR at a time. I'll merge this and cut a new release today. |
Remove `pip bundle` from pip2pi
This uses
pip install -d ...
instead ofpip bundle
to pre-package the .tar.gz files.